From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH][v2 3/3] VMX: x86: Only reset MMU when necessary
Date: Wed, 12 May 2010 11:47:36 +0300 [thread overview]
Message-ID: <4BEA6B28.9060404@redhat.com> (raw)
In-Reply-To: <1273653642-23132-4-git-send-email-sheng@linux.intel.com>
On 05/12/2010 11:40 AM, Sheng Yang wrote:
> Only modifying some bits of CR0/CR4 needs paging mode switch.
>
> Modify EFER.NXE bit would result in reserved bit updates.
>
> Signed-off-by: Sheng Yang<sheng@linux.intel.com>
> ---
> arch/x86/kvm/x86.c | 16 ++++++++++++++--
> 1 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 764f89b..f442da2 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -416,6 +416,10 @@ out:
>
> static int __kvm_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0)
> {
> + unsigned long old_cr0 = kvm_read_cr0(vcpu);
> + unsigned long update_bits = X86_CR0_PG | X86_CR0_WP |
> + X86_CR0_CD | X86_CR0_NW;
> +
>
CR0_WP...
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-05-12 8:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 8:40 [PATCH][v2 0/3] Some MMU related fix/clean up Sheng Yang
2010-05-12 8:40 ` [PATCH][v2 1/3] KVM: x86: Check LMA bit before set_efer Sheng Yang
2010-05-12 8:40 ` [PATCH][v2 2/3] KVM: Clean up duplicate assignment Sheng Yang
2010-05-12 8:40 ` [PATCH][v2 3/3] VMX: x86: Only reset MMU when necessary Sheng Yang
2010-05-12 8:47 ` Avi Kivity [this message]
[not found] ` <201005121654.34980.sheng@linux.intel.com>
2010-05-12 8:56 ` Avi Kivity
2010-05-13 22:18 ` [PATCH][v2 0/3] Some MMU related fix/clean up Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEA6B28.9060404@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).