From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] x86 emulator: Add missing decoder flags for sub instruction Date: Wed, 12 May 2010 12:37:14 +0300 Message-ID: <4BEA76CA.9020808@redhat.com> References: <1273617562-6275-1-git-send-email-m.gamal005@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Mohammed Gamal Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39791 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717Ab0ELJh0 (ORCPT ); Wed, 12 May 2010 05:37:26 -0400 In-Reply-To: <1273617562-6275-1-git-send-email-m.gamal005@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/12/2010 01:39 AM, Mohammed Gamal wrote: > This adds missing decoder flags for sub instructions (opcodes 0x2c - 0x2d) > > Looks good (both patches). Please post test cases for realmode.c. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.