From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH 1/2] close all the block drivers before the qemu process exits Date: Wed, 12 May 2010 17:28:31 +0300 Message-ID: <4BEABB0F.9030907@redhat.com> References: <1273661213-19611-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> <1273661213-19611-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, sheepdog@lists.wpkg.org, fujita.tomonori@lab.ntt.co.jp To: MORITA Kazutaka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10934 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753901Ab0ELO3Z (ORCPT ); Wed, 12 May 2010 10:29:25 -0400 In-Reply-To: <1273661213-19611-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 05/12/2010 01:46 PM, MORITA Kazutaka wrote: > This patch calls the close handler of the block driver before the qemu > process exits. > > This is necessary because the sheepdog block driver releases the lock > of VM images in the close handler. > > How do you handle abnormal termination? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.