From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/7] Consolidate vcpu ioctl locking Date: Thu, 13 May 2010 15:01:41 +0300 Message-ID: <4BEBEA25.8080309@redhat.com> References: <1273749459-622-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, kvm-ia64@vger.kernel.org, kvm-ppc@vger.kernel.org, carsteno@de.ibm.com To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38623 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753020Ab0EMMBs (ORCPT ); Thu, 13 May 2010 08:01:48 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 05/13/2010 02:57 PM, Alexander Graf wrote: > > Mind to give a high level overview on where you're moving which locks? > > Um, looks like I forgot to fill in the patchset header. Sorry. The patches move all vcpu ioctl locking from the individual ioctl handlers (e.g. kvm_vcpu_ioctl_set_cpuid()) to the top-level vcpu ioctl handler (kvm_vcpu_ioctl()). So tons of vcpu_load()/vcpu_put() pairs (some of the missing) get replaced by a single pair. -- error compiling committee.c: too many arguments to function