From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/7] Consolidate vcpu ioctl locking Date: Thu, 13 May 2010 15:03:58 +0300 Message-ID: <4BEBEAAE.9030502@redhat.com> References: <1273749459-622-1-git-send-email-avi@redhat.com> <4BEBEA25.8080309@redhat.com> <4BEBEA7E.80202@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org To: Alexander Graf Return-path: In-Reply-To: <4BEBEA7E.80202-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 05/13/2010 03:03 PM, Avi Kivity wrote: > On 05/13/2010 03:01 PM, Avi Kivity wrote: >> On 05/13/2010 02:57 PM, Alexander Graf wrote: >>> >>> Mind to give a high level overview on where you're moving which locks? >>> >> >> Um, looks like I forgot to fill in the patchset header. Sorry. > > Gar, I actually wrote it but forgot to save the file. > And it had some useful info: [PATCH 0/7] Consolidate vcpu ioctl locking In general, all vcpu ioctls need to take the vcpu mutex, but each one does it (or not) individually. This is cumbersome and error prone. This patchset moves all locking to a central place. This is complicated by the fact that ppc's KVM_INTERRUPT and s390's KVM_S390_INTERRUPT break the convention and need to run unlocked. -- error compiling committee.c: too many arguments to function