From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/7] Consolidate vcpu ioctl locking Date: Thu, 13 May 2010 15:29:51 +0300 Message-ID: <4BEBF0BF.2020404@redhat.com> References: <1273749459-622-1-git-send-email-avi@redhat.com> <4BEBEA25.8080309@redhat.com> <4BEBEA7E.80202@redhat.com> <4BEBEAAE.9030502@redhat.com> <24423079-CDE0-4DEA-BC73-3B6976BE0CA6@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org To: Alexander Graf Return-path: In-Reply-To: <24423079-CDE0-4DEA-BC73-3B6976BE0CA6-l3A5Bk7waGM@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 05/13/2010 03:18 PM, Alexander Graf wrote: > >> [PATCH 0/7] Consolidate vcpu ioctl locking >> >> In general, all vcpu ioctls need to take the vcpu mutex, but each one does it >> (or not) individually. This is cumbersome and error prone. >> >> This patchset moves all locking to a central place. This is complicated >> by the fact that ppc's KVM_INTERRUPT and s390's KVM_S390_INTERRUPT break >> the convention and need to run unlocked. >> > Why is the x86 non-kernel-pic path different? > Userspace issues the ioctl from a vcpu thread. It has to, btw, since whether an interrupt can be injected or not depends on vcpu-synchronous registers: eflags.if and tpr/cr8. -- error compiling committee.c: too many arguments to function