From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v5 4/5] Inter-VM shared memory PCI device Date: Sat, 15 May 2010 09:05:00 +0300 Message-ID: <4BEE398C.3070004@redhat.com> References: <1271872408-22842-1-git-send-email-cam@cs.ualberta.ca> <1271872408-22842-2-git-send-email-cam@cs.ualberta.ca> <1271872408-22842-3-git-send-email-cam@cs.ualberta.ca> <1271872408-22842-4-git-send-email-cam@cs.ualberta.ca> <1271872408-22842-5-git-send-email-cam@cs.ualberta.ca> <4BE7F517.5010707@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org To: Cam Macdonell Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47750 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716Ab0EOGFJ (ORCPT ); Sat, 15 May 2010 02:05:09 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 05/14/2010 12:10 AM, Cam Macdonell wrote: > On Mon, May 10, 2010 at 5:59 AM, Avi Kivity wrote: > >> On 04/21/2010 08:53 PM, Cam Macdonell wrote: >> > >>> + >>> + /* allocate/initialize space for interrupt handling */ >>> + s->eventfds = qemu_mallocz(s->nr_alloc_guests * sizeof(int *)); >>> + s->eventfd_table = qemu_mallocz(s->vectors * >>> sizeof(EventfdEntry)); >>> + s->eventfds_posn_count = qemu_mallocz(s->nr_alloc_guests * >>> sizeof(int)); >>> + >>> + pci_conf[PCI_INTERRUPT_PIN] = 1; /* we are going to support >>> interrupts */ >>> >>> >> This is done by the guest BIOS. >> >> >> > If I remove that line, my driver crashes when it falls back to > pin-based interrupts (when MSI is turned off). Is there something in > the device driver that I need to set in place of this? A number of > other devices (mostly network cards) set the interrupt pin this way, > so I'm a little confused. > Sorry, I confused this with PCI_INTERRUPT_LINE. Note there is a helper to set it, pci_config_set_interrupt_pin(). -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.