From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][v2 1/3] x86: Export FPU API for KVM use Date: Mon, 17 May 2010 12:24:47 +0300 Message-ID: <4BF10B5F.5030300@redhat.com> References: <1274087308-26676-1-git-send-email-sheng@linux.intel.com> <1274087308-26676-2-git-send-email-sheng@linux.intel.com> <4BF10A06.5040902@redhat.com> <201005171719.23570.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , "H. Peter Anvin" , Ingo Molnar , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Sheng Yang Return-path: In-Reply-To: <201005171719.23570.sheng@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 05/17/2010 12:19 PM, Sheng Yang wrote: > On Monday 17 May 2010 17:19:02 Avi Kivity wrote: > >> On 05/17/2010 12:08 PM, Sheng Yang wrote: >> >>> Also add some constants. >>> >>> >>> +++ b/arch/x86/kernel/process.c >>> @@ -28,6 +28,7 @@ unsigned long idle_nomwait; >>> >>> EXPORT_SYMBOL(idle_nomwait); >>> >>> struct kmem_cache *task_xstate_cachep; >>> >>> +EXPORT_SYMBOL(task_xstate_cachep); >>> >>> int arch_dup_task_struct(struct task_struct *dst, struct task_struct >>> *src) { >>> >> _GPL() unless good reason not to. >> > Oops... Just copied and pasted the above line... > > No matter, I'll update it when applying if no further comments (reviewing 3 now). -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.