From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/3] KVM: MMU: split kvm_sync_page() function Date: Wed, 19 May 2010 19:19:24 +0300 Message-ID: <4BF40F8C.4050608@redhat.com> References: <4BEE7CAC.5020603@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , LKML , KVM list To: Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19912 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943Ab0ESQTb (ORCPT ); Wed, 19 May 2010 12:19:31 -0400 In-Reply-To: <4BEE7CAC.5020603@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/15/2010 01:51 PM, Xiao Guangrong wrote: > Split kvm_sync_page() into kvm_sync_page() and kvm_sync_page_transient() > to clarify the code address Avi's suggestion > > kvm_sync_page_transient() function only update shadow page but not mark > it sync and not write protect sp->gfn. it will be used by later patch > Applied all three, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.