From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH qemu-kvm] device-assignment: add config fd qdev property
Date: Wed, 19 May 2010 16:50:35 -0500
Message-ID: <4BF45D2B.8020000@codemonkey.ws>
References: <20100519190041.GK28275@x200.localdomain> <4BF4398B.50902@codemonkey.ws> <20100519211030.GL28275@x200.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Alex Williamson <alex.williamson@redhat.com>
To: Chris Wright <chrisw@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-yw0-f180.google.com ([209.85.211.180]:42017 "EHLO
	mail-yw0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751731Ab0ESVuo (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 19 May 2010 17:50:44 -0400
Received: by ywh10 with SMTP id 10so4601655ywh.1
        for <kvm@vger.kernel.org>; Wed, 19 May 2010 14:50:43 -0700 (PDT)
In-Reply-To: <20100519211030.GL28275@x200.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 05/19/2010 04:10 PM, Chris Wright wrote:
> * Anthony Liguori (anthony@codemonkey.ws) wrote:
>    
>> An fd as a qdev property seems like a bad idea to me.
>>      
> What is your concern?
>    

qdev properties are supposed to represent device tunables.  A file 
descriptor is not a tunable.

It's like passing the tap device fd via qdev to an e1000.

>> I'm not sure I have a better suggestion though.
>>      
> Anything else requires inventing some new commandline options and monitor
> comnmands (-pcidevice anyone? ;-).  I'm not sure the benefit, esp with
> hopes of moving to uio.
>    

Yeah, I think device passthrough is going to require new command line 
syntax to be more qemu friendly...

Regards,

Anthony Liguori

> thanks,
> -chris
>