Re: [PATCH 1/2] trace: Add simple tracing support

Jan Kiszka
2010-05-21T11:14:00Z

Stefan Hajnoczi wrote:
> Trace events should be defined in trace.h. Events are written to
> /tmp/trace.log and can be formatted using trace.py. Remember to add
> events to trace.py for pretty-printing.

When already writing to a file, why not reusing QEMU's logging
infrastructure ("log <foo>" / "-d foo")? Shouldn't make a huge
performance difference if the data is saved in clear-text.

Also, having support for ftrace's user space markers would be a very
nice option (only an option as it's Linux-specific), see
http://lwn.net/Articles/366796. This allows to correlate kernel events
(KVM as well as others) with what goes on in QEMU. It simply enables
integration with the whole kernel tracing infrastructure, e.g.
KernelShark (http://people.redhat.com/srostedt/kernelshark/HTML).

Jan

--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux