From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH qemu-kvm 2/2] device-assignment: Don't use libpci Date: Sun, 23 May 2010 14:08:31 +0300 Message-ID: <4BF90CAF.4010809@redhat.com> References: <20100520135537.18663.70947.stgit@virtlab9.virt.bos.redhat.com> <20100520220608.GX13880@x200.localdomain> <20100521002323.GZ13880@x200.localdomain> <20100521002541.GA13880@x200.localdomain> <20100521002715.GB13880@x200.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Alex Williamson To: Chris Wright Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26998 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752198Ab0EWLId (ORCPT ); Sun, 23 May 2010 07:08:33 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4NB8Xk4007189 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 23 May 2010 07:08:33 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4NB8WT1016279 for ; Sun, 23 May 2010 07:08:32 -0400 In-Reply-To: <20100521002715.GB13880@x200.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 05/21/2010 03:27 AM, Chris Wright wrote: > From: Alex Williamson > > We've already got an open fd for PCI config space for the device, we > might as well use it. This also makes sure that if we're making use of > a privileged file descriptor opened for us, we use it for all accesses > to the device. > Applied both thanks. -- error compiling committee.c: too many arguments to function