From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] fix "info cpus" halted state display Date: Sun, 23 May 2010 14:26:07 +0300 Message-ID: <4BF910CF.1080500@redhat.com> References: <20100513131714.GC7757@redhat.com> <20100520101617.GE15750@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56509 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951Ab0EWL0K (ORCPT ); Sun, 23 May 2010 07:26:10 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4NBQ9Us014227 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 23 May 2010 07:26:09 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4NBQ8P4024129 for ; Sun, 23 May 2010 07:26:09 -0400 In-Reply-To: <20100520101617.GE15750@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/20/2010 01:16 PM, Gleb Natapov wrote: > On Thu, May 13, 2010 at 04:17:14PM +0300, Gleb Natapov wrote: > >> When in-kernel irqchip is used env->halted is never used for anything >> except "info cpus" command. Halted state is synced in >> kvm_arch_save_mpstate() and showed by do_info_cpus() but otherwise never >> looked at. Zeroing it here breaks "info cpus" since before >> do_info_cpus() outputs env->halted in io thread it is zeroed here when >> vcpu thread reenters kernel. >> >> > Avi, what about this patch? > > Sorry, missed. Applied now. -- error compiling committee.c: too many arguments to function