From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/4] Fix tboot enabled macro Date: Wed, 26 May 2010 11:38:19 +0300 Message-ID: <4BFCDDFB.9010505@redhat.com> References: <4BFC9686.9050300@redhat.com> <4BFCCCFD.20203@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Zachary Amsden , kvm , Gleb Natapov , Shane Wang To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:14924 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751654Ab0EZIiW (ORCPT ); Wed, 26 May 2010 04:38:22 -0400 In-Reply-To: <4BFCCCFD.20203@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 05/26/2010 10:25 AM, Jan Kiszka wrote: > > This is for CONFIG_INTEL_TXT enabled? Good point but needs to be solved > differently. tboot, the variable that is checked by the original header, > is not exported to modules. I wonder how this worked out for you... > > Solution should be: hack tboot_enabled to kvm_tboot_enabled and > unconditionally define that to 0 for older kernels. If tboot is actually > enabled in hardware, KVM may not load but I'm unsure if it's OK to > assume tboot == 1 for that case or if that will cause breakages if it's > off instead - CC'ing the KVM patch author. > Worst case it doesn't load. I don't think it's a problem since enabling tboot will be rare for older kernels. -- error compiling committee.c: too many arguments to function