From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm <kvm@vger.kernel.org>, Joerg Roedel <joerg.roedel@amd.com>,
Zachary Amsden <zamsden@redhat.com>
Subject: [PATCH] KVM: Fix order passed to iommu_unmap
Date: Wed, 26 May 2010 21:29:10 +0200 [thread overview]
Message-ID: <4BFD7686.2030109@web.de> (raw)
From: Jan Kiszka <jan.kiszka@siemens.com>
This is obviously a left-over from the the old interface taking the
size. Apparently a mostly harmless issue with the current iommu_unmap
implementation.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
virt/kvm/iommu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/virt/kvm/iommu.c b/virt/kvm/iommu.c
index 5adc578..8b96251 100644
--- a/virt/kvm/iommu.c
+++ b/virt/kvm/iommu.c
@@ -273,7 +273,7 @@ static void kvm_iommu_put_pages(struct kvm *kvm,
pfn = phys >> PAGE_SHIFT;
/* Unmap address from IO address space */
- order = iommu_unmap(domain, gfn_to_gpa(gfn), PAGE_SIZE);
+ order = iommu_unmap(domain, gfn_to_gpa(gfn), 1);
unmap_pages = 1ULL << order;
/* Unpin all pages we just unmapped to not leak any memory */
--
1.6.0.2
next reply other threads:[~2010-05-26 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 19:29 Jan Kiszka [this message]
2010-05-26 19:36 ` [PATCH v2] KVM: Fix order passed to iommu_unmap Jan Kiszka
2010-05-27 10:08 ` Roedel, Joerg
2010-05-27 12:40 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFD7686.2030109@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).