From: Avi Kivity <avi@redhat.com>
To: Julia Lawall <julia@diku.dk>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Xiantao Zhang <xiantao.zhang@intel.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
kvm@vger.kernel.org, kvm-ia64@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 10/17] arch/ia64/kvm: Add missing spin_unlock
Date: Thu, 27 May 2010 16:20:25 +0300 [thread overview]
Message-ID: <4BFE7199.7060609@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1005261756490.23743@ask.diku.dk>
On 05/26/2010 06:57 PM, Julia Lawall wrote:
> From: Julia Lawall<julia@diku.dk>
>
> Add a spin_unlock missing on the error path.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //<smpl>
> @@
> expression E1;
> @@
>
> * spin_lock(E1,...);
> <+... when != E1
> if (...) {
> ... when != E1
> * return ...;
> }
> ...+>
> * spin_unlock(E1,...);
> //</smpl>
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
next parent reply other threads:[~2010-05-27 13:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.1005261756490.23743@ask.diku.dk>
2010-05-27 13:20 ` Avi Kivity [this message]
2010-05-26 15:57 [PATCH 10/17] arch/ia64/kvm: Add missing spin_unlock Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFE7199.7060609@redhat.com \
--to=avi@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=tony.luck@intel.com \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).