From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 10/17] arch/ia64/kvm: Add missing spin_unlock Date: Thu, 27 May 2010 16:20:25 +0300 Message-ID: <4BFE7199.7060609@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Xiantao Zhang , Tony Luck , Fenghua Yu , kvm@vger.kernel.org, kvm-ia64@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org To: Julia Lawall Return-path: In-Reply-To: Sender: linux-ia64-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 05/26/2010 06:57 PM, Julia Lawall wrote: > From: Julia Lawall > > Add a spin_unlock missing on the error path. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression E1; > @@ > > * spin_lock(E1,...); > <+... when != E1 > if (...) { > ... when != E1 > * return ...; > } > ...+> > * spin_unlock(E1,...); > // > > Applied, thanks. -- error compiling committee.c: too many arguments to function