From: Jason Wang <jasowang@redhat.com>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v2 00/10] Redirct and make use of the guest serial console
Date: Fri, 28 May 2010 16:19:29 +0800 [thread overview]
Message-ID: <4BFF7C91.2000907@redhat.com> (raw)
In-Reply-To: <1274799038.2456.44.camel@freedom>
Lucas Meneghel Rodrigues wrote:
> On Tue, 2010-05-11 at 17:03 +0800, Jason Wang wrote:
>
>> The guest console is useful for failure troubleshooting especially for
>> the one who has calltrace. And as we plan to push the network related
>> test in the next few weeks, we found the serial session in more
>> reliable during the network testing. So this patchset logs the guest
>> serial throught the redirectied serial of guest and also enable the
>> ability to log into guest through serial console. I only open the
>> serial console for linux, I would do some investigation on windows
>> guests.
>>
>> Change from v1:
>>
>> - Coding style improvement according to the suggestions from Michael Goldish
>> - Improve the username sending handling in remote_login()
>> - Change the matching re of login to [Ll]ogin:\s*$
>> - Check whether vm have already dead in dumpping thread
>> - Return none rather than raise exception when met unknown shell_client
>> - Keep tty0 for all linux guests
>> - Enable the serial console in unattended installation
>> - Add a helper to check whether the panic information was occured
>> - Keep the porcess() at its original location in preprocess()
>>
>
> Jason, after a long conversation I've had with Michael during the
> previous week, we reached some common points:
>
> 1 - We believe it is possible to be able to both log in *and* log serial
> console output. That will require changes to kvm_subprocess and might
> take a little bit more time.
>
Yes, I've tried a ugly implementation of a server in serial_dump_thread
( finally dropped from my patch ), so I agree that it would be much more
elegant if I can get the support from kvm_subprocess.
> 2 - We know you guys are depending on this patchset to be accepted in
> order to proceed with the network related cases. However, we ask for a
> little more patience, and we'd like to get your opinions on the patches
> that we are going to roll out. This way we can get to a better solution
> for all of us.
>
> So, please bear with us and I'll try to see with Michael and Dor if we
> can prioritize this work to not block work items for you guys.
>
> Cheers,
>
> Lucas
>
>
Ok, no problem.
prev parent reply other threads:[~2010-05-28 8:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 9:03 [PATCH v2 00/10] Redirct and make use of the guest serial console Jason Wang
2010-05-11 9:03 ` [PATCH v2 01/10] KVM test: Introduce prompt assist Jason Wang
2010-05-12 22:00 ` Lucas Meneghel Rodrigues
2010-05-11 9:03 ` [PATCH v2 02/10] KVM test: Send the username in remote_login() Jason Wang
2010-05-11 9:03 ` [PATCH v2 03/10] KVM test: Make the login re suitable for serial console Jason Wang
2010-05-11 9:03 ` [PATCH v2 04/10] KVM test: Redirect the serial to the unix domain socket Jason Wang
2010-05-11 9:03 ` [PATCH v2 05/10] KVM test: Log the content from guest serial console Jason Wang
2010-05-11 9:03 ` [PATCH v2 06/10] KVM test: Return none when met unknown type in kvm_vm.remote_login() Jason Wang
2010-05-11 9:04 ` [PATCH v2 07/10] KVM test: Introduce local_login() Jason Wang
2010-05-11 9:04 ` [PATCH v2 08/10] KVM test: Enable the serial console for all linux guests Jason Wang
2010-05-11 9:04 ` [PATCH v2 09/10] KVM test: Enable the serial console during unattended installation Jason Wang
2010-05-11 9:04 ` [PATCH v2 10/10] KVM test: Add a helper to search the panic in the log Jason Wang
2010-05-12 9:44 ` Michael Goldish
2010-05-17 7:28 ` Jason Wang
2010-05-17 21:23 ` Lucas Meneghel Rodrigues
2010-05-25 14:50 ` [PATCH v2 00/10] Redirct and make use of the guest serial console Lucas Meneghel Rodrigues
2010-05-28 8:19 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFF7C91.2000907@redhat.com \
--to=jasowang@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lmr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).