From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH v2 00/10] Redirct and make use of the guest serial console Date: Fri, 28 May 2010 16:19:29 +0800 Message-ID: <4BFF7C91.2000907@redhat.com> References: <20100511083338.19914.7719.stgit@localhost.localdomain> <1274799038.2456.44.camel@freedom> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Lucas Meneghel Rodrigues Return-path: In-Reply-To: <1274799038.2456.44.camel@freedom> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: autotest-bounces@test.kernel.org Errors-To: autotest-bounces@test.kernel.org List-Id: kvm.vger.kernel.org Lucas Meneghel Rodrigues wrote: > On Tue, 2010-05-11 at 17:03 +0800, Jason Wang wrote: > >> The guest console is useful for failure troubleshooting especially for >> the one who has calltrace. And as we plan to push the network related >> test in the next few weeks, we found the serial session in more >> reliable during the network testing. So this patchset logs the guest >> serial throught the redirectied serial of guest and also enable the >> ability to log into guest through serial console. I only open the >> serial console for linux, I would do some investigation on windows >> guests. >> >> Change from v1: >> >> - Coding style improvement according to the suggestions from Michael Goldish >> - Improve the username sending handling in remote_login() >> - Change the matching re of login to [Ll]ogin:\s*$ >> - Check whether vm have already dead in dumpping thread >> - Return none rather than raise exception when met unknown shell_client >> - Keep tty0 for all linux guests >> - Enable the serial console in unattended installation >> - Add a helper to check whether the panic information was occured >> - Keep the porcess() at its original location in preprocess() >> > > Jason, after a long conversation I've had with Michael during the > previous week, we reached some common points: > > 1 - We believe it is possible to be able to both log in *and* log serial > console output. That will require changes to kvm_subprocess and might > take a little bit more time. > Yes, I've tried a ugly implementation of a server in serial_dump_thread ( finally dropped from my patch ), so I agree that it would be much more elegant if I can get the support from kvm_subprocess. > 2 - We know you guys are depending on this patchset to be accepted in > order to proceed with the network related cases. However, we ask for a > little more patience, and we'd like to get your opinions on the patches > that we are going to roll out. This way we can get to a better solution > for all of us. > > So, please bear with us and I'll try to see with Michael and Dor if we > can prioritize this work to not block work items for you guys. > > Cheers, > > Lucas > > Ok, no problem.