From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Add Documentation/kvm/msr.txt Date: Sun, 30 May 2010 12:14:21 +0300 Message-ID: <4C022C6D.7070701@redhat.com> References: <1274897088-8587-1-git-send-email-glommer@redhat.com> <4BFE2A2F.50209@redhat.com> <20100527160248.GF3445@mothafucka.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, zamsden@redhat.com To: Glauber Costa Return-path: In-Reply-To: <20100527160248.GF3445@mothafucka.localdomain> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 05/27/2010 07:02 PM, Glauber Costa wrote: >> >>> + >>> +Custom MSR list >>> +-------- >>> + >>> +The current supported Custom MSR list is: >>> + >>> +MSR_KVM_WALL_CLOCK: 0x11 >>> + >>> + data: physical address of a memory area. >>> >> Which must be in guest RAM (i.e., don't point it somewhere random >> and expect the hypervisor to allocate it for you). >> >> Must be aligned to 4 bytes (we don't enforce it though). >> > I don't see the reason for it. > Insurance. > If this is a requirement, our own implementation > is failing to meet it. > How are we failing to meet it? All guests align to at least four bytes. -- error compiling committee.c: too many arguments to function