From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, zamsden@redhat.com
Subject: Re: [PATCH] Add Documentation/kvm/msr.txt
Date: Mon, 31 May 2010 17:03:29 +0300 [thread overview]
Message-ID: <4C03C1B1.8010102@redhat.com> (raw)
In-Reply-To: <20100531134906.GA19104@mothafucka.localdomain>
On 05/31/2010 04:49 PM, Glauber Costa wrote:
>
>> How are we failing to meet it? All guests align to at least four bytes.
>>
> static struct pvclock_wall_clock wall_clock;
>
> Unless there is something that the compiler does that I should take for granted,
> there is no alignment directive in there, and it could be anywhere.
>
The compiler will align u32 and larger to 4 bytes on i386 (and align u64
to 8 bytes on x86_64).
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2010-05-31 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 18:04 [PATCH] Add Documentation/kvm/msr.txt Glauber Costa
2010-05-26 18:35 ` Randy Dunlap
2010-05-26 18:59 ` Glauber Costa
2010-05-27 8:15 ` Avi Kivity
2010-05-27 16:02 ` Glauber Costa
2010-05-27 20:13 ` Zachary Amsden
2010-05-27 20:36 ` Glauber Costa
2010-05-27 21:02 ` Zachary Amsden
2010-05-28 0:10 ` Glauber Costa
2010-05-28 4:10 ` Zachary Amsden
2010-05-30 9:14 ` Avi Kivity
2010-05-31 13:49 ` Glauber Costa
2010-05-31 14:03 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C03C1B1.8010102@redhat.com \
--to=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).