From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Add Documentation/kvm/msr.txt Date: Mon, 31 May 2010 17:03:29 +0300 Message-ID: <4C03C1B1.8010102@redhat.com> References: <1274897088-8587-1-git-send-email-glommer@redhat.com> <4BFE2A2F.50209@redhat.com> <20100527160248.GF3445@mothafucka.localdomain> <4C022C6D.7070701@redhat.com> <20100531134906.GA19104@mothafucka.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, zamsden@redhat.com To: Glauber Costa Return-path: In-Reply-To: <20100531134906.GA19104@mothafucka.localdomain> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 05/31/2010 04:49 PM, Glauber Costa wrote: > >> How are we failing to meet it? All guests align to at least four bytes. >> > static struct pvclock_wall_clock wall_clock; > > Unless there is something that the compiler does that I should take for granted, > there is no alignment directive in there, and it could be anywhere. > The compiler will align u32 and larger to 4 bytes on i386 (and align u64 to 8 bytes on x86_64). -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.