public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] KVM VMX: Make sure single type invvpid is supported before issuing this instruction
@ 2010-06-03  8:44 Gui Jianfeng
  2010-06-03  8:57 ` Sheng Yang
  0 siblings, 1 reply; 8+ messages in thread
From: Gui Jianfeng @ 2010-06-03  8:44 UTC (permalink / raw)
  To: Avi Kivity; +Cc: Sheng Yang, kvm

According to SDM, we need check whether single-context INVVPID type is supported
before issuing invvpid instruction.

Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
 arch/x86/include/asm/vmx.h |    2 ++
 arch/x86/kvm/vmx.c         |    8 +++++++-
 2 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
index 104cf86..6fa40d0 100644
--- a/arch/x86/include/asm/vmx.h
+++ b/arch/x86/include/asm/vmx.h
@@ -376,6 +376,8 @@ enum vmcs_field {
 #define VMX_EPT_EXTENT_CONTEXT_BIT		(1ull << 25)
 #define VMX_EPT_EXTENT_GLOBAL_BIT		(1ull << 26)
 
+#define VMX_EPT_INVVPID_SINGLE_CONTEXT_BIT      (1ull << (41 - 32))
+
 #define VMX_EPT_DEFAULT_GAW			3
 #define VMX_EPT_MAX_GAW				0x4
 #define VMX_EPT_MT_EPTE_SHIFT			3
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 0e561a5..e2d12bf 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -355,6 +355,11 @@ static inline bool cpu_has_vmx_invept_global(void)
 	return vmx_capability.ept & VMX_EPT_EXTENT_GLOBAL_BIT;
 }
 
+static inline bool cpu_has_vmx_invvpid_single(void)
+{
+	return vmx_capability.vpid & VMX_EPT_INVVPID_SINGLE_CONTEXT_BIT;
+}
+
 static inline bool cpu_has_vmx_ept(void)
 {
 	return vmcs_config.cpu_based_2nd_exec_ctrl &
@@ -499,7 +504,8 @@ static inline void vpid_sync_vcpu_all(struct vcpu_vmx *vmx)
 	if (vmx->vpid == 0)
 		return;
 
-	__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
+	if (cpu_has_vmx_invvpid_single())
+		__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
 }
 
 static inline void ept_sync_global(void)
-- 
1.6.5.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2010-06-04 18:20 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-03  8:44 [PATCH] KVM VMX: Make sure single type invvpid is supported before issuing this instruction Gui Jianfeng
2010-06-03  8:57 ` Sheng Yang
2010-06-03  9:07   ` Gui Jianfeng
2010-06-03  9:45   ` [PATCH v2] KVM VMX: Make sure single type invvpid is supported before issuing invvpid instruction Gui Jianfeng
2010-06-03  9:58     ` Sheng Yang
2010-06-04  0:51       ` [PATCH v3] " Gui Jianfeng
2010-06-04  5:40         ` Sheng Yang
2010-06-04 17:51         ` Marcelo Tosatti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox