From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup Date: Fri, 04 Jun 2010 16:06:59 +0200 Message-ID: <4C090883.70704@redhat.com> References: <1275270181-10992-1-git-send-email-nab@linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Gerd Hoffmann , Christoph Hellwig , Hannes Reinecke , Paul Brook , kvm-devel , qemu-devel To: "Nicholas A. Bellinger" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17130 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755722Ab0FDOHr (ORCPT ); Fri, 4 Jun 2010 10:07:47 -0400 In-Reply-To: <1275270181-10992-1-git-send-email-nab@linux-iscsi.org> Sender: kvm-owner@vger.kernel.org List-ID: Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: > From: Nicholas Bellinger > > This patch updates hw/scsi-bus.c to add PERSISTENT_RESERVE_OUT and PERSISTENT_RESERVE_IN > case in scsi_req_length() to extra the incoming buffer length into SCSIRequest->cmd.xfer, > and adds a second PERSISTENT_RESERVE_OUT case in scsi_req_xfer_mode() in order to properly > set SCSI_XFER_TO_DEV for WRITE data. > > Tested with Linux KVM guests and Megasas 8708EM2 HBA emulation and TCM_Loop target ports. > > Signed-off-by: Nicholas A. Bellinger > --- > hw/scsi-bus.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c > index b8e4b71..75ec74e 100644 > --- a/hw/scsi-bus.c > +++ b/hw/scsi-bus.c > @@ -325,6 +325,10 @@ static int scsi_req_length(SCSIRequest *req, uint8_t *cmd) > case INQUIRY: > req->cmd.xfer = cmd[4] | (cmd[3] << 8); > break; > + case PERSISTENT_RESERVE_OUT: > + case PERSISTENT_RESERVE_IN: > + req->cmd.xfer = cmd[8] | (cmd[7] << 8); Maybe I'm missing something, but isn't exactly the same value set in the switch block above? (for cmd[0] >> 5 == 2) Kevin