From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH v2 3/4] KVM: MMU: Atomically check for accessed bit when
 dropping an spte
Date: Tue, 08 Jun 2010 10:07:38 +0800
Message-ID: <4C0DA5EA.80009@cn.fujitsu.com>
References: <1275894659-17656-1-git-send-email-avi@redhat.com> <1275894659-17656-4-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:50556 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1752077Ab0FHCLJ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 7 Jun 2010 22:11:09 -0400
In-Reply-To: <1275894659-17656-4-git-send-email-avi@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



Avi Kivity wrote:
 
> +static u64 __xchg_spte(u64 *sptep, u64 new_spte)
> +{
> +#ifdef CONFIG_X86_64
> +	return xchg(sptep, new_spte);
> +#else
> +	u64 old_spte;
> +
> +	do {
> +		old_spte = *sptep;
> +	} while (cmpxchg64(sptep, old_spte, new_spte) != old_spte);
> +
> +	return old;

it's a typo: 'old' -> 'old_spte' :-)