Re: [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset

Alex Williamson
2010-06-08T21:12:50Z

On Tue, 2010-06-08 at 15:12 -0500, Anthony Liguori wrote:
> On 06/08/2010 02:16 PM, Alex Williamson wrote:
> > if (is_dup_page(p, *p)) {
> > - qemu_put_be64(f, current_addr | RAM_SAVE_FLAG_COMPRESS);
> > + qemu_put_be64(f, offset | RAM_SAVE_FLAG_COMPRESS);
> > + qemu_put_buffer(f, (uint8_t *)block->name, sizeof(block->name));
> > qemu_put_byte(f, *p);
> >
>
> I think we could use some trickery like use another flag in
> current_address to determine whether this was a different section from
> the previous section and then only encode the section name if that's true.

Good suggestion, see patch 7/6 ;)

Alex