From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC][PATCH 3/3] In DM_LOWEST, only deliver interrupts to vcpus with enabled LAPIC's Date: Wed, 09 Jun 2010 14:08:31 +0300 Message-ID: <4C0F762F.2030605@redhat.com> References: <1276019703-18136-1-git-send-email-clalance@redhat.com> <1276019703-18136-4-git-send-email-clalance@redhat.com> <20100609110132.GX14316@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Chris Lalancette , kvm@vger.kernel.org, mtosatti@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51176 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757332Ab0FILId (ORCPT ); Wed, 9 Jun 2010 07:08:33 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o59B8Whi017176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 9 Jun 2010 07:08:33 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o59B8Wgu007396 for ; Wed, 9 Jun 2010 07:08:32 -0400 In-Reply-To: <20100609110132.GX14316@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/09/2010 02:01 PM, Gleb Natapov wrote: > On Tue, Jun 08, 2010 at 01:55:03PM -0400, Chris Lalancette wrote: > >> Otherwise we might try to deliver a timer interrupt to a cpu that >> can't possibly handle it. >> >> Signed-off-by: Chris Lalancette >> --- >> virt/kvm/irq_comm.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c >> index 52f412f..06cf61e 100644 >> --- a/virt/kvm/irq_comm.c >> +++ b/virt/kvm/irq_comm.c >> @@ -100,7 +100,7 @@ int kvm_irq_delivery_to_apic(struct kvm *kvm, struct kvm_lapic *src, >> if (r< 0) >> r = 0; >> r += kvm_apic_set_irq(vcpu, irq); >> - } else { >> + } else if (kvm_lapic_enabled(vcpu)) { >> if (!lowest) >> lowest = vcpu; >> else if (kvm_apic_compare_prio(vcpu, lowest)< 0) >> > Shouldn't we check kvm_lapic_enabled(vcpu) at the beginning of the loop? > Something like: > if (!kvm_apic_present(vcpu) || !kvm_lapic_enabled(vcpu)) > continue; > > The apic still accepts some interrupts even if disabled, so this needs to be very conditional. -- error compiling committee.c: too many arguments to function