From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [KVM-AUTOTEST PATCH v2 1/4] KVM test: support -kernel and -append command line options Date: Wed, 09 Jun 2010 15:03:18 +0300 Message-ID: <4C0F8306.70509@redhat.com> References: <1276033807-22718-1-git-send-email-mgoldish@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Michael Goldish Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17252 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757249Ab0FIMDV (ORCPT ); Wed, 9 Jun 2010 08:03:21 -0400 In-Reply-To: <1276033807-22718-1-git-send-email-mgoldish@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/09/2010 12:50 AM, Michael Goldish wrote: > Signed-off-by: Michael Goldish > --- > client/tests/kvm/kvm_vm.py | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py > index 94bacdf..f3c05f3 100755 > --- a/client/tests/kvm/kvm_vm.py > +++ b/client/tests/kvm/kvm_vm.py > @@ -268,6 +268,12 @@ class VM: > def add_pcidevice(help, host): > return " -pcidevice host=%s" % host > > + def add_kernel(help, filename): > + return " -kernel %s" % filename > + > + def add_kernel_cmdline(help, cmdline): > + return " -append %s" % cmdline > + > Shell quoting is a good idea here. Everywhere else too, in fact, but -append is very likely to contain spaces. -- error compiling committee.c: too many arguments to function