From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Goldish <mgoldish@redhat.com>
Subject: Re: [KVM-AUTOTEST PATCH v2 1/4] KVM test: support
 -kernel and -append command line options
Date: Wed, 09 Jun 2010 18:25:02 +0300
Message-ID: <4C0FB24E.3030206@redhat.com>
References: <1276033807-22718-1-git-send-email-mgoldish@redhat.com>
	<4C0F8306.70509@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <autotest-bounces@test.kernel.org>
In-Reply-To: <4C0F8306.70509@redhat.com>
List-Unsubscribe: <http://test.kernel.org/cgi-bin/mailman/listinfo/autotest>,
	<mailto:autotest-request@test.kernel.org?subject=unsubscribe>
List-Archive: <http://test.kernel.org/pipermail/autotest>
List-Post: <mailto:autotest@test.kernel.org>
List-Help: <mailto:autotest-request@test.kernel.org?subject=help>
List-Subscribe: <http://test.kernel.org/cgi-bin/mailman/listinfo/autotest>,
	<mailto:autotest-request@test.kernel.org?subject=subscribe>
Sender: autotest-bounces@test.kernel.org
Errors-To: autotest-bounces@test.kernel.org
List-Id: kvm.vger.kernel.org

On 06/09/2010 03:03 PM, Avi Kivity wrote:
> On 06/09/2010 12:50 AM, Michael Goldish wrote:
>> Signed-off-by: Michael Goldish<mgoldish@redhat.com>
>> ---
>>   client/tests/kvm/kvm_vm.py |   15 +++++++++++++++
>>   1 files changed, 15 insertions(+), 0 deletions(-)
>>
>> diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
>> index 94bacdf..f3c05f3 100755
>> --- a/client/tests/kvm/kvm_vm.py
>> +++ b/client/tests/kvm/kvm_vm.py
>> @@ -268,6 +268,12 @@ class VM:
>>           def add_pcidevice(help, host):
>>               return " -pcidevice host=%s" % host
>>
>> +        def add_kernel(help, filename):
>> +            return " -kernel %s" % filename
>> +
>> +        def add_kernel_cmdline(help, cmdline):
>> +            return " -append %s" % cmdline
>> +
>>    
> 
> Shell quoting is a good idea here.  Everywhere else too, in fact, but
> -append is very likely to contain spaces.
> 

Thanks.  I'll fix that for all parameters in a new patch.