Re: [KVM-AUTOTEST PATCH v2 1/4] KVM test: support -kernel and -append command line options

Avi Kivity
2010-06-09T12:03:21Z

On 06/09/2010 12:50 AM, Michael Goldish wrote:
> Signed-off-by: Michael Goldish<mgoldish@redhat.com>
> ---
> client/tests/kvm/kvm_vm.py | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
> index 94bacdf..f3c05f3 100755
> --- a/client/tests/kvm/kvm_vm.py
> +++ b/client/tests/kvm/kvm_vm.py
> @@ -268,6 +268,12 @@ class VM:
> def add_pcidevice(help, host):
> return " -pcidevice host=%s" % host
>
> + def add_kernel(help, filename):
> + return " -kernel %s" % filename
> +
> + def add_kernel_cmdline(help, cmdline):
> + return " -append %s" % cmdline
> +
>

Shell quoting is a good idea here. Everywhere else too, in fact, but
-append is very likely to contain spaces.

--
error compiling committee.c: too many arguments to function