From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] Re: KVM call minutes for June 8 Date: Wed, 09 Jun 2010 11:26:35 -0500 Message-ID: <4C0FC0BB.7060806@codemonkey.ws> References: <20100608150500.GA28492@x200.localdomain> <4C0E694F.8040607@codemonkey.ws> <20100608175952.5f43ea8f@redhat.com> <4C0EB281.80907@codemonkey.ws> <20100609121820.1f3bb47a@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Chris Wright , qemu-devel@nongnu.org, kvm@vger.kernel.org, armbru@redhat.com To: Luiz Capitulino Return-path: Received: from mail-gw0-f46.google.com ([74.125.83.46]:44901 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752762Ab0FIQ0k (ORCPT ); Wed, 9 Jun 2010 12:26:40 -0400 Received: by gwj15 with SMTP id 15so187140gwj.19 for ; Wed, 09 Jun 2010 09:26:40 -0700 (PDT) In-Reply-To: <20100609121820.1f3bb47a@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/09/2010 10:18 AM, Luiz Capitulino wrote: >> The big problem is things like the block io error events. I don't see >> how we can support that given what we have in 0.13. Putting errno on >> the wire is a bad idea. We need to marshal a QError object using the >> __class__ memory to identify it as QError and pass that with the event. >> It could potentially be made to work for 0.13 but it'll be ugly. >> > Yes, that's the main problem of the whole thing I think. > > From QEMU pov, the best thing to do would be to let this event as it's > today and wait for the new QError (it's a compatible change, anyway). > I'd prefer that we just send the event with an embedded qerror (using __class__). We can generate it directly instead of using qerror_report/qerror_new. It's ugly but it'll work and be future compatible. For now, let's just support a few types of qerror to basically distinguish between an unknown io error and ENOSPC. > However, libvirt was counting on this feature and on the snapshot commands > to switch from the text Monitor. We have two options: > I don't think snapshots are actually usable by libvirt in the current form. Regards, Anthony LIguori > 1. Ask them to wait one more release (not so good for us) > 2. Try to find a way to have those features in for 0.13 > > Daniel has commented to me that making the snapshot commands synchronous > for 0.13 wouldn't be that bad, what do you think? >