public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] kvm, x86: use ro page and don't copy shared page
Date: Thu, 10 Jun 2010 10:47:07 +0800	[thread overview]
Message-ID: <4C10522B.8000503@cn.fujitsu.com> (raw)
In-Reply-To: <4C0F5EAB.3030401@redhat.com>

Avi Kivity wrote:

> Wierd.  For what gfn/pfns does this trigger?
> 

It is ZERO_PAGE which also has Reserved bit, not mmio page.
The pte is set write-protected, I still don't know why it cause the system
hangup.

set_spte() {
	if (tdp_enabled)
		spte |= kvm_x86_ops->get_mt_mask(vcpu, gfn,
			kvm_is_mmio_pfn(pfn));

	/* guest can write to the page because of this statement? */
}

  reply	other threads:[~2010-06-10  2:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-09  7:53 [RFC PATCH 2/2] kvm, x86: use ro page and don't copy shared page Lai Jiangshan
2010-06-09  9:28 ` Avi Kivity
2010-06-10  2:47   ` Lai Jiangshan [this message]
2010-06-10 11:19   ` Lai Jiangshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C10522B.8000503@cn.fujitsu.com \
    --to=laijs@cn.fujitsu.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox