Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field

Paul Brook
2010-06-11T16:13:39Z

> The trouble I'm running into is that the SaveStateEntry.instance_id is
> effectively private, and there's no easy way to associate a
> SaveStateEntry to a device since it passes an opaque pointer, which
> could be whatever the driver decides it wants. I'm wondering if we
> should pass the DeviceState pointer in when registering the vmstate so
> that we can stuff the instance_id into the DeviceInfo. Or maybe
> DeviceInfo should include a pointer to the SaveStateEntry. It all seems
> pretty messy. Any thoughts?

DeviceInfo is effectively a const structure (it may be modified at startup,
but there's only one of it shared between multiple devices). I suspect you
mean DeviceState.

Most likely a lot of the messyness is because we still have devices that have
not been qdev-ified, so the VMState code can't assume it has a device. We
should fix this.

Paul