Re: [RFC][PATCH 0/3]: Fixes to IRQ routing

Avi Kivity
2010-06-09T11:02:30Z

On 06/08/2010 08:55 PM, Chris Lalancette wrote:
> As we've discussed previously, here is a series of patches to
> fix some of the IRQ routing issues we have in KVM. With this series
> in place I was able to successfully kdump a RHEL-5 64-bit, and RHEL-6
> 32- and 64-bit guest on CPU's other than the BSP. RHEL-5 32-bit kdump still
> does not work; it gets stuck on "Checking 'hlt' instruction". However,
> it does that both before and after this series, so there is something
> else going on there that I still have to debug.
>
> I also need to change the "kvm_migrate_pit_timer" function to migrate the
> timer over to the last CPU that handled the timer interrupt, on the
> theory that that particlar CPU is likely to handle the timer interrupt again
> in the near future.
>
> The other outstanding question about these patches is how to setup the
> workqueue. As it stands I have a single workqueue for all guests. However,
> for efficiency reasons we may want to have one workqueue per guest. Opinions?
>

Perhaps a singlethreaded workqueue per guest? Or perhaps just
schedule_work(), and let the kernel worry about the details?

--
error compiling committee.c: too many arguments to function