From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCHv2] virtio-net: stop vhost backend on vmstop Date: Thu, 10 Jun 2010 09:28:33 -0500 Message-ID: <4C10F691.7040201@codemonkey.ws> References: <20100602180152.GA21861@redhat.com> <20100604170316.GC25107@amt.cnet> <20100610141955.GA1814@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:40087 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759273Ab0FJO2i (ORCPT ); Thu, 10 Jun 2010 10:28:38 -0400 Received: by iwn37 with SMTP id 37so7077032iwn.19 for ; Thu, 10 Jun 2010 07:28:37 -0700 (PDT) In-Reply-To: <20100610141955.GA1814@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/10/2010 09:19 AM, Michael S. Tsirkin wrote: > On Fri, Jun 04, 2010 at 02:03:16PM -0300, Marcelo Tosatti wrote: > >> On Wed, Jun 02, 2010 at 09:01:52PM +0300, Michael S. Tsirkin wrote: >> >>> vhost net currently keeps running after vmstop, >>> which causes trouble as qemy does not check >>> for dirty pages anymore. >>> The fix is to simply keep vm and vhost running/stopped >>> status in sync. >>> >>> Tested-by: David L Stevens >>> Signed-off-by: Michael S. Tsirkin >>> --- >>> >>> Changes from v1: >>> Simplify code as suggested by Amit. >>> >>> hw/virtio-net.c | 11 +++++------ >>> 1 files changed, 5 insertions(+), 6 deletions(-) >>> >> Applied, thanks. >> > Heh, wrong list, this is actually an upstream patch. > I sent Anthony a merge request with it, hope this > won't create problems. > git will figure it out. Regards, Anthony Liguori