From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers Date: Fri, 11 Jun 2010 07:56:01 +0300 Message-ID: <4C11C1E1.2050300@redhat.com> References: <4c0eb470.1HMjondO00NIvFM6%pugs@cisco.com> <20100610172736.GA9737@phenom.dumpdata.com> <201006101858.38491.pugs@lyon-about.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Konrad Rzeszutek Wilk , randy.dunlap@oracle.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, chrisw@sous-sol.org, joro@8bytes.org, hjk@linutronix.de, mst@redhat.com, gregkh@suse.de, aafabbri@cisco.com, scofeldm@cisco.com To: Tom Lyon Return-path: In-Reply-To: <201006101858.38491.pugs@lyon-about.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 06/11/2010 04:58 AM, Tom Lyon wrote: > On Thursday 10 June 2010 10:27:36 am Konrad Rzeszutek Wilk wrote: > >>> +EXPORT_SYMBOL(uiommu_fdget); >>> >> EXPORT_SYMBOL_GPL >> .. snip >> >>> +EXPORT_SYMBOL(uiommu_put); >>> >> ditto. >> >> > Is there a definitive explanation somewhere of when to use each? > Always use _GPL unless you have a defensible reason why you shouldn't. The kernel's license if GPL, exporting a symbol without GPL can be seen as adding an exception to the license. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.