From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prerna Saxena Subject: Re: [Qemu-devel] [PATCH 1/3] export tdb_hash() Date: Fri, 11 Jun 2010 16:02:23 +0530 Message-ID: <4C1210B7.7090703@linux.vnet.ibm.com> References: <20100608122803.6a684a5e@zephyr> <20100608123138.353f46f3@zephyr> <20100609173506.454225c7@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, Anthony Liguori , Stefan Hajnoczi , kvm@vger.kernel.org, Kiszka , maneesh@linux.vnet.ibm.com, ananth@linux.vnet.ibm.com, Jan@us.ibm.com To: Luiz Capitulino Return-path: Received: from e23smtp05.au.ibm.com ([202.81.31.147]:39888 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756041Ab0FKKc3 (ORCPT ); Fri, 11 Jun 2010 06:32:29 -0400 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [202.81.31.247]) by e23smtp05.au.ibm.com (8.14.4/8.13.1) with ESMTP id o5BASOVv029855 for ; Fri, 11 Jun 2010 20:28:24 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5BAWRF21400982 for ; Fri, 11 Jun 2010 20:32:27 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o5BAWRwf010885 for ; Fri, 11 Jun 2010 20:32:27 +1000 In-Reply-To: <20100609173506.454225c7@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/10/2010 02:05 AM, Luiz Capitulino wrote: > On Tue, 8 Jun 2010 12:31:38 +0530 > Prerna Saxena wrote: > >> This exports tdb_hash() for use by tracing framework. > > Suggest to rename it (eg. qemu_hash()) and move it to a better location, qdict > is not the best module to export such service. > Would 'qemu-common.h' be a good place to export it ? If not, any suggestions on where else I can export it ? I havent renamed it in v2 of patches that I sent out. I'll send out a cumulative patch that renames and exports tdb_hash() from an appropriate location. Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India