Re: [Qemu-devel] [RFC v2] [PATCH 0/3] Monitor Support for 'simple' trace backend

[Jan Kiszka <jan.kiszka@siemens.com>]

Markus Armbruster wrote:
> Prerna Saxena <prerna@linux.vnet.ibm.com> writes:
> 
>> This is v2 of monitor commands based on Stefan's trace framework :
>> ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html )
>>
>> This adds the following monitor commands for the 'simple' backend:
>> - info trace 		: to view current contents of the trace buffer.
>> - info tracepoints 	: to view all available tracepoints and their 
>> 			  state.
>> - tracepoint NAME on|off: to enable/disable the logging of data from 
>> 			  tracepoint 'NAME'.
>>
>>
>> Changelog :
>> - Command 'info trace' is used to view current contents of buffer, in 
>> place of 'trace'.
>> - Cleanups
> 
> Do we want this in QMP?

For sure IMO. Maybe not in a hurry to avoid breakages until the whole
tracing infrastructure has settled, but long-term to ease scripting etc.

Still, let's not add this as an old-style monitor command, rather
convert it to the new style, maybe blocking QMP for now. I'll post the
required infrastructure for that blocking along my next device_show
series (hopefully the next days).

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux