From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [RFC v2] [PATCH 0/3] Monitor Support for 'simple' trace backend Date: Fri, 11 Jun 2010 14:08:56 +0200 Message-ID: <4C122758.4020808@siemens.com> References: <20100611003811.2635fa5d@zephyr> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Prerna Saxena , "qemu-devel@nongnu.org" , Anthony Liguori , Stefan Hajnoczi , "kvm@vger.kernel.org" , Luiz Capitulino , "maneesh@linux.vnet.ibm.com" , "ananth@linux.vnet.ibm.com" To: Markus Armbruster Return-path: Received: from david.siemens.de ([192.35.17.14]:24483 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760190Ab0FKMJX (ORCPT ); Fri, 11 Jun 2010 08:09:23 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Markus Armbruster wrote: > Prerna Saxena writes: > >> This is v2 of monitor commands based on Stefan's trace framework : >> ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html ) >> >> This adds the following monitor commands for the 'simple' backend: >> - info trace : to view current contents of the trace buffer. >> - info tracepoints : to view all available tracepoints and their >> state. >> - tracepoint NAME on|off: to enable/disable the logging of data from >> tracepoint 'NAME'. >> >> >> Changelog : >> - Command 'info trace' is used to view current contents of buffer, in >> place of 'trace'. >> - Cleanups > > Do we want this in QMP? For sure IMO. Maybe not in a hurry to avoid breakages until the whole tracing infrastructure has settled, but long-term to ease scripting etc. Still, let's not add this as an old-style monitor command, rather convert it to the new style, maybe blocking QMP for now. I'll post the required infrastructure for that blocking along my next device_show series (hopefully the next days). Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux