From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH v3] KVM: x86: XSAVE/XRSTOR live migration support
Date: Sun, 13 Jun 2010 12:13:00 +0300 [thread overview]
Message-ID: <4C14A11C.9020409@redhat.com> (raw)
In-Reply-To: <201006131710.03560.sheng@linux.intel.com>
On 06/13/2010 12:10 PM, Sheng Yang wrote:
>
>>> +
>>> +static int kvm_vcpu_ioctl_x86_set_xcrs(struct kvm_vcpu *vcpu,
>>> + struct kvm_xcrs *guest_xcrs)
>>> +{
>>> + int i, r = 0;
>>> +
>>> + if (!cpu_has_xsave)
>>> + return -EINVAL;
>>>
>> Too strict?
>>
> For no cpu_has_xsave, the KVM_CAP_XCRS would return 0, so this ioctl shouldn't be
> called.
>
Right.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-06-13 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 4:36 [PATCH v3] KVM: x86: XSAVE/XRSTOR live migration support Sheng Yang
2010-06-13 8:26 ` Avi Kivity
2010-06-13 9:10 ` Sheng Yang
2010-06-13 9:13 ` Avi Kivity [this message]
2010-06-13 9:29 ` [PATCH v4] " Sheng Yang
2010-06-14 20:33 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C14A11C.9020409@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox