From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v3] KVM: x86: XSAVE/XRSTOR live migration support
Date: Sun, 13 Jun 2010 12:13:00 +0300
Message-ID: <4C14A11C.9020409@redhat.com>
References: <1276230971-5990-1-git-send-email-sheng@linux.intel.com> <4C14962A.9030608@redhat.com> <201006131710.03560.sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:43213 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753198Ab0FMJNE (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 13 Jun 2010 05:13:04 -0400
In-Reply-To: <201006131710.03560.sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 06/13/2010 12:10 PM, Sheng Yang wrote:
>
>>> +
>>> +static int kvm_vcpu_ioctl_x86_set_xcrs(struct kvm_vcpu *vcpu,
>>> +				       struct kvm_xcrs *guest_xcrs)
>>> +{
>>> +	int i, r = 0;
>>> +
>>> +	if (!cpu_has_xsave)
>>> +		return -EINVAL;
>>>        
>> Too strict?
>>      
> For no cpu_has_xsave, the KVM_CAP_XCRS would return 0, so this ioctl shouldn't be
> called.
>    

Right.

-- 
error compiling committee.c: too many arguments to function