Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

Markus Armbruster
2010-06-16T13:02:21Z

Jan Kiszka <jan.kiszka@siemens.com> writes:

> Markus Armbruster wrote:
>> Jan Kiszka <jan.kiszka@siemens.com> writes:
[...]
>>> The format I will propose is "global-ID|/absolute/path", no more
>>> /path/global-ID as this comes with the risk of ambiguity (ID may shadow
>>> bus-local name of a device).
>>
>> Doesn't this break existing usage?
>
> Please name one. It could only be weird corner cases like "device_add
> driver,bus=bus1/ID/bus2" or "bus=ID/bus". But given that we always
> allowed to address "bus2" directly (and this is something I cannot and
> will not change), does this really matter? Maybe allowing paths to start
> with an ID is something worth considering, will think about this again.

I checked with Dan: libvirt doesn't care. So I don't either. …