From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: KVM call minutes for June 15 Date: Tue, 15 Jun 2010 11:13:20 -0500 Message-ID: <4C17A6A0.2010203@codemonkey.ws> References: <20100615151812.GA24131@x200.localdomain> <20100615154153.GA2707@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Chris Wright , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Christoph Hellwig Return-path: Received: from mail-gw0-f46.google.com ([74.125.83.46]:40857 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751196Ab0FOQNM (ORCPT ); Tue, 15 Jun 2010 12:13:12 -0400 Received: by gwj15 with SMTP id 15so3318721gwj.19 for ; Tue, 15 Jun 2010 09:13:11 -0700 (PDT) In-Reply-To: <20100615154153.GA2707@infradead.org> Sender: kvm-owner@vger.kernel.org List-ID: On 06/15/2010 10:41 AM, Christoph Hellwig wrote: > On Tue, Jun 15, 2010 at 08:18:12AM -0700, Chris Wright wrote: > >> KVM/qemu patches >> - patch rate is high, documentation is low, review is low >> - patches need to include better descriptions and documentation >> - will slow down patch writers >> - will make it easier for patch reviewers >> > What is the qemu patch review policy anyway? We don't really have a coherent policy. Suggestions for improvement are always appreciated. > There are no > "Reviewed-by:" included in the actual commits, Reviewed-by/Ack-by's are pretty helpful for me. In terms of including them in commit messages, if there's a strong feeling that that would be helpful then it's something I can look at doing but it also requires a fair bit of manual work during commit. > and the requirement > for a positive review also seem to vary a lot, up to the point that > some commiters commit code that has never hit a public mailing list > before. > That really shouldn't happen and if it does, please point it out on the list. Regards, Anthony Liguori > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >