From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v3] qemu: kvm: Enable XSAVE live migration support Date: Thu, 17 Jun 2010 09:26:13 +0200 Message-ID: <4C19CE15.6050604@web.de> References: <1276231009-6060-1-git-send-email-sheng@linux.intel.com> <4C18F25E.8070704@siemens.com> <20100616160544.GA3826@amt.cnet> <201006171001.59401.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigBB63CB6C8E797298F65CC53E" Cc: Marcelo Tosatti , Avi Kivity , Anthony Liguori , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Sheng Yang Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:51146 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859Ab0FQH0O (ORCPT ); Thu, 17 Jun 2010 03:26:14 -0400 In-Reply-To: <201006171001.59401.sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBB63CB6C8E797298F65CC53E Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sheng Yang wrote: > On Thursday 17 June 2010 00:05:44 Marcelo Tosatti wrote: >> On Wed, Jun 16, 2010 at 05:48:46PM +0200, Jan Kiszka wrote: >>> Marcelo Tosatti wrote: >>>> On Fri, Jun 11, 2010 at 12:36:49PM +0800, Sheng Yang wrote: >>>>> Signed-off-by: Sheng Yang >>>>> --- >>>>> >>>>> qemu-kvm-x86.c | 109 >>>>> ++++++++++++++++++++++++++++++++++++++++--------- qemu-kvm.c = =20 >>>>> | 24 +++++++++++ >>>>> qemu-kvm.h | 28 +++++++++++++ >>>>> target-i386/cpu.h | 5 ++ >>>>> target-i386/kvm.c | 2 + >>>>> target-i386/machine.c | 20 +++++++++ >>>>> 6 files changed, 169 insertions(+), 19 deletions(-) >>>> Applied, thanks. >>> Oops, late remark: Why introducing this feature against qemu-kvm inst= ead >>> of upstream? Doesn't this just generate additional conversion work an= d >>> the risk of divergence to upstream in the migration protocol? >=20 > Hi Jan >=20 > You're late... Hope you could raise the comment earlier next time so we= can work=20 > together more efficient. This case is "lost", probably was already when you posted the first time. But I hope we can raise awareness for the issue that way again. >> Thats true. Sheng, can you add save/restore support to uq/master to >> avoid these problems? >=20 > Yes, there is divergence risk, would send an upstream version as well. >=20 > But I think as long as qemu-kvm and qemu upstream use different LM path= , the=20 > duplicate code/work can't be avoid.=20 Probably. The vision is that one day you can write a KVM feature and apply it to qemu-kvm as a staging tree for later unmodified merge into qemu upstream. qemu-kvm[-arch].[ch] is still in our way, but it already uses many bits from upstream. So I would recommend to design new features against upstream first and then provide the few bits to also make use of it in qemu-kvm once the latter has merged the required bits (which may actually happen before upstream, but that doesn't matter). Jan --------------enigBB63CB6C8E797298F65CC53E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkwZzhUACgkQitSsb3rl5xSocQCgmeZjbdoc/NO4CrmfwzEhxNDu Ok8AoO8DAkevIK3ipKE68kAmIqarwx22 =tBtn -----END PGP SIGNATURE----- --------------enigBB63CB6C8E797298F65CC53E--