From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH 6/6] KVM: MMU: trace pte prefetch
Date: Thu, 17 Jun 2010 15:27:44 +0800
Message-ID: <4C19CE70.9000002@cn.fujitsu.com>
References: <4C16E6ED.7020009@cn.fujitsu.com> <4C16E75F.6020003@cn.fujitsu.com> <4C16E7AD.1060101@cn.fujitsu.com> <4C16E7F4.5060801@cn.fujitsu.com> <4C16E82E.5010306@cn.fujitsu.com> <4C16E867.8040606@cn.fujitsu.com> <4C16E9AF.2090501@cn.fujitsu.com> <4C176D71.7060302@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	KVM list <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <4C176D71.7060302@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



Avi Kivity wrote:

>> @@ -2066,11 +2071,16 @@ static void direct_pte_prefetch(struct
>> kvm_vcpu *vcpu, u64 *sptep)
>>           pfn = gfn_to_pfn_atomic(vcpu->kvm, gfn);
>>           if (is_error_pfn(pfn)) {
>>               kvm_release_pfn_clean(pfn);
>> +            trace_pte_prefetch(true, PREFETCH_ERR_GFN2PFN);
>>               break;
>>           }
>>    
> 
> What about virtual addresses and gptes?  They can be helpful too.
> 

OK, will do it in the next version.