From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Yongjun Subject: Re: [PATCH] KVM: x86 emulator: fix group3 instruction decoding Date: Fri, 18 Jun 2010 08:51:42 +0800 Message-ID: <4C1AC31E.6010900@cn.fujitsu.com> References: <4C16D0A0.2090203@cn.fujitsu.com> <20100616140927.GA1662@amt.cnet> <4C19EC03.50509@cn.fujitsu.com> <4C1A0E74.5060906@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:49568 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751953Ab0FRAyS (ORCPT ); Thu, 17 Jun 2010 20:54:18 -0400 In-Reply-To: <4C1A0E74.5060906@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: > On 06/17/2010 12:33 PM, Wei Yongjun wrote: >> Group 3 instruction with ModRM reg field as 001 is >> defined as test instruction under AMD arch, and >> emulate_grp3() is ready for emulate it, so fix the >> decoding. >> >> > > Strange but true. > > Did you encounter any situation which actually needed this, or did you > find this by code inspection? Just found it by source review, looks strange, so...