From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86 emulator: fix group3 instruction decoding Date: Sun, 20 Jun 2010 11:24:53 +0300 Message-ID: <4C1DD055.2000603@redhat.com> References: <4C16D0A0.2090203@cn.fujitsu.com> <20100616140927.GA1662@amt.cnet> <4C19EC03.50509@cn.fujitsu.com> <4C1A0E74.5060906@redhat.com> <4C1AC31E.6010900@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Wei Yongjun Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39409 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755234Ab0FTIZB (ORCPT ); Sun, 20 Jun 2010 04:25:01 -0400 In-Reply-To: <4C1AC31E.6010900@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/18/2010 03:51 AM, Wei Yongjun wrote: > >> On 06/17/2010 12:33 PM, Wei Yongjun wrote: >> >>> Group 3 instruction with ModRM reg field as 001 is >>> defined as test instruction under AMD arch, and >>> emulate_grp3() is ready for emulate it, so fix the >>> decoding. >>> >>> >>> >> Strange but true. >> >> Did you encounter any situation which actually needed this, or did you >> find this by code inspection? >> > Just found it by source review, looks strange, so... > Well, the emulator usually puts me to sleep, so good catch. Applied the patch, thanks. -- error compiling committee.c: too many arguments to function