public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Carsten Otte <cotte@de.ibm.com>
Subject: Re: kvm-s390: Dont exit SIE on SIGP sense running
Date: Mon, 21 Jun 2010 11:27:50 +0300	[thread overview]
Message-ID: <4C1F2286.7090108@redhat.com> (raw)
In-Reply-To: <201006172316.21684.borntraeger@de.ibm.com>

On 06/18/2010 12:16 AM, Christian Borntraeger wrote:
> Avi, Marcello,
>
> Newer (guest) kernels use sigp sense running in their spinlock
> implementation to check if the other cpu is running before yielding
> the processor. This revealed some wrong guest settings, causing
> unnecessary exits for every sigp sense running.
>    

Applied, thanks.

>   void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu)
>   {
>   	VCPU_EVENT(vcpu, 3, "%s", "free cpu");
> +	clear_bit(63 - vcpu->vcpu_id, (unsigned long *)&vcpu->kvm->arch.sca->mcn);
>   	if (vcpu->kvm->arch.sca->cpu[vcpu->vcpu_id].sda ==
>   		(__u64) vcpu->arch.sie_block)
>   		vcpu->kvm->arch.sca->cpu[vcpu->vcpu_id].sda = 0;
>    

Unrelated, do these VCPU_EVENTs want to become ftrace tracepoints?

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2010-06-21  8:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 21:16 kvm-s390: Dont exit SIE on SIGP sense running Christian Borntraeger
2010-06-21  8:27 ` Avi Kivity [this message]
2010-06-21 10:15   ` Christian Borntraeger
2010-06-21 10:26     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1F2286.7090108@redhat.com \
    --to=avi@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cotte@de.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox