From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: kvm-s390: Dont exit SIE on SIGP sense running Date: Mon, 21 Jun 2010 11:27:50 +0300 Message-ID: <4C1F2286.7090108@redhat.com> References: <201006172316.21684.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, Heiko Carstens , Martin Schwidefsky , Carsten Otte To: Christian Borntraeger Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37916 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754428Ab0FUI1y (ORCPT ); Mon, 21 Jun 2010 04:27:54 -0400 In-Reply-To: <201006172316.21684.borntraeger@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/18/2010 12:16 AM, Christian Borntraeger wrote: > Avi, Marcello, > > Newer (guest) kernels use sigp sense running in their spinlock > implementation to check if the other cpu is running before yielding > the processor. This revealed some wrong guest settings, causing > unnecessary exits for every sigp sense running. > Applied, thanks. > void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu) > { > VCPU_EVENT(vcpu, 3, "%s", "free cpu"); > + clear_bit(63 - vcpu->vcpu_id, (unsigned long *)&vcpu->kvm->arch.sca->mcn); > if (vcpu->kvm->arch.sca->cpu[vcpu->vcpu_id].sda == > (__u64) vcpu->arch.sie_block) > vcpu->kvm->arch.sca->cpu[vcpu->vcpu_id].sda = 0; > Unrelated, do these VCPU_EVENTs want to become ftrace tracepoints? -- error compiling committee.c: too many arguments to function