From: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 1/2] KVM: PPC: Add generic hpte management functions
Date: Tue, 22 Jun 2010 15:20:43 +0300 [thread overview]
Message-ID: <4C20AA9B.8000807@redhat.com> (raw)
In-Reply-To: <4C20A91A.1080607-l3A5Bk7waGM@public.gmane.org>
On 06/22/2010 03:14 PM, Alexander Graf wrote:
> Avi Kivity wrote:
>
>> On 06/22/2010 03:10 PM, Alexander Graf wrote:
>>
>>> If you have more performance hints, I'll gladly take them :).
>>>
>>>
>> Using a cpu that virtualizes the mmu in hardware helps tremendously.
>>
>>
> PPC never does that. Even with the virtualization extensions the MMU is
> still software managed.
Then mmu intensive loads can expect to be slow.
> I was also more thinking of hints like
> "kmem_cache_zalloc is slow" or so ;).
>
Stuff like that is usually worthless. To give real feedback I need to
understand the hardware, so I'm reduced to coding style and indentation
review.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-06-22 12:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 13:44 [PATCH 1/2] KVM: PPC: Add generic hpte management functions Alexander Graf
2010-06-21 13:44 ` [PATCH 2/2] KVM: PPC: Make use of hash based Shadow MMU Alexander Graf
[not found] ` <1277127841-32704-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-22 12:02 ` [PATCH 1/2] KVM: PPC: Add generic hpte management functions Avi Kivity
[not found] ` <4C20A64D.2070805-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-22 12:04 ` Alexander Graf
2010-06-22 12:07 ` Avi Kivity
2010-06-22 12:10 ` Alexander Graf
[not found] ` <4C20A836.2010908-l3A5Bk7waGM@public.gmane.org>
2010-06-22 12:12 ` Avi Kivity
2010-06-22 12:14 ` Alexander Graf
[not found] ` <4C20A91A.1080607-l3A5Bk7waGM@public.gmane.org>
2010-06-22 12:20 ` Avi Kivity [this message]
[not found] ` <4C20AA9B.8000807-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-26 22:58 ` Benjamin Herrenschmidt
2010-06-27 7:53 ` Avi Kivity
2010-06-27 22:10 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2010-06-30 13:18 [PATCH 0/2] Faster MMU lookups for Book3s v3 Alexander Graf
[not found] ` <1277903926-12786-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-30 13:18 ` [PATCH 1/2] KVM: PPC: Add generic hpte management functions Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C20AA9B.8000807@redhat.com \
--to=avi-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=agraf-l3A5Bk7waGM@public.gmane.org \
--cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox